[ofa-general] Re: Merging of completely unreviewed drivers
Krzysztof Halasa
khc at pm.waw.pl
Fri Feb 22 14:28:58 PST 2008
Al Viro <viro at ZenIV.linux.org.uk> writes:
> IMO the line length overruns make good warnings. Not as in "here's a cheap
> way to get more changesets", but as in "that code might have other problems
> nearby" kind of heuristics.
Sure, it does. However the human looking at the code is far better at
spotting such problems. Machine-generated warnings are great when the
machine is actually better than human.
Anyway, warnings are one thing and line limit is another. We may raise
the limit leaving the 80-chars warning in place. Unless there are too
many false positives, of course.
--
Krzysztof Halasa
More information about the general
mailing list