[ofa-general] Re: [PATCH RFC] opensm/ib_types.h: remove ifdef WIN conditions

Sasha Khapyorsky sashak at voltaire.com
Tue Jan 8 07:49:47 PST 2008


Hi Hal,

On 07:03 Mon 07 Jan     , Hal Rosenstock wrote:
> On Sun, 2008-01-06 at 15:43 +0000, Sasha Khapyorsky wrote:
> > It was stated couple of times that in windows another instance of
> > ib_types.h file is used. If so we don't need to keep those 'ifdef WIN'
> > conditions here. Also this removes empty __ptr64 macro.
> 
> Shouldn't this also be sent to ofw for comments ?

I will forward this to ofw for sure, but don't expect a lot of interest
- if it is not used there.

> Also, ib_cm_types.h looks like it should be changed as well in terms of
> this.

This file seems to be unused at all, likely we could just remove it.

> Since master and ofed_1_3 are no longer identical, please indicate for
> which branch(es) patches are intended.

As usual everything is for the master if otherwise is not indicated.

Sasha



More information about the general mailing list