[ofa-general] Re: [PATCH RFC] opensm/ib_types.h: remove ifdef WIN conditions

[Hal Rosenstock]

Sasha,

On Tue, 2008-01-08 at 15:49 +0000, Sasha Khapyorsky wrote:
> Hi Hal,
> 
> On 07:03 Mon 07 Jan     , Hal Rosenstock wrote:
> > On Sun, 2008-01-06 at 15:43 +0000, Sasha Khapyorsky wrote:
> > > It was stated couple of times that in windows another instance of
> > > ib_types.h file is used. If so we don't need to keep those 'ifdef WIN'
> > > conditions here. Also this removes empty __ptr64 macro.
> > 
> > Shouldn't this also be sent to ofw for comments ?
> 
> I will forward this to ofw for sure, but don't expect a lot of interest
> - if it is not used there.

I think it is a courtesy for ofw to do this in case they don't follow
the general list as this is removing some of their definitions.

> > Also, ib_cm_types.h looks like it should be changed as well in terms of
> > this.
> 
> This file seems to be unused at all, likely we could just remove it.

This was done for an out of tree consumer a while ago (those definitions
were originally in ib_types.h). There was a thread on general a while
ago on this and I think a closed bug too. I can dig it out if you can't.

-- Hal

> > Since master and ofed_1_3 are no longer identical, please indicate for
> > which branch(es) patches are intended.
> 
> As usual everything is for the master if otherwise is not indicated.

> Sasha