[ofa-general] lock dependency in ib_user_mad

Sean Hefty sean.hefty at intel.com
Mon Jan 14 13:02:27 PST 2008


>@@ -703,7 +708,8 @@ static int ib_umad_unreg_agent(struct ib_umad_file *file,
>u32 __user *arg)
> 	if (get_user(id, arg))
> 		return -EFAULT;
>
>-	down_write(&file->port->mutex);
>+	mutex_unlock(&file->port->file_mutex);

This should be mutex_lock().

The other changes look okay.  With your latest patch and the change above, I was
not able to reproduce the lockdep warnings.  (I've seen the warnings 3 or 4
times now, but it's not easy to reproduce.) 

Thanks
- Sean




More information about the general mailing list