[ofa-general] lock dependency in ib_user_mad

Roland Dreier rdreier at cisco.com
Mon Jan 14 13:24:51 PST 2008


 > >-	down_write(&file->port->mutex);
 > >+	mutex_unlock(&file->port->file_mutex);
 > 
 > This should be mutex_lock().

Yup, thanks... I fixed it in my tree.  I guess I never tested
unregistering a MAD agent...

 > The other changes look okay.  With your latest patch and the change above, I was
 > not able to reproduce the lockdep warnings.  (I've seen the warnings 3 or 4
 > times now, but it's not easy to reproduce.) 

OK, thanks.  I think these changes are an improvement anyway, so I
guess I'll queue them up for 2.6.25 and hope things are fixed...

 - R.



More information about the general mailing list