[ofa-general] Re: [PATCH 1/3 v2] libibverbs : add new verbs: create_qp_expanded

[Roland Dreier]

 > --- a/src/cmd.c
 > +++ b/src/cmd.c
 > @@ -625,8 +625,18 @@ int ibv_cmd_create_qp(struct ibv_pd *pd,
 >  		      struct ibv_create_qp *cmd, size_t cmd_size,
 >  		      struct ibv_create_qp_resp *resp, size_t resp_size)
 >  {
 > -	IBV_INIT_CMD_RESP(cmd, cmd_size, CREATE_QP, resp, resp_size);
 > +	return ibv_cmd_create_qp_expanded(pd, qp, attr,	0, cmd, cmd_size, resp, resp_size);
 > +}

Guys, please try to be careful about compatibility... we care about both
new-kernel/old-libibverbs and old-kernel/new-libibverbs.  In this case
think about what happens if we merge this into libibverbs and then a
user tries that code on an old kernel.

 - R.