[ofa-general] Re: [PATCH 1/3 v2] libibverbs : add new verbs: create_qp_expanded

[Ron Livne]

> +    return ibv_cmd_create_qp_expanded(pd, qp, attr, 0, cmd, cmd_size, resp, resp_size);
Roland, you are right. This is not a good solution for
old-kernel/new-libibverbs.
It seems that I will have to create a bit messier code (extracting
common code in 2 functions into 1 function) in order to avoid the
compatibility issue.

Maybe you thought of a better way?

Ron


On Tue, Jul 22, 2008 at 8:21 AM, Roland Dreier <rdreier at cisco.com> wrote:
>  > --- a/src/cmd.c
>  > +++ b/src/cmd.c
>  > @@ -625,8 +625,18 @@ int ibv_cmd_create_qp(struct ibv_pd *pd,
>  >                    struct ibv_create_qp *cmd, size_t cmd_size,
>  >                    struct ibv_create_qp_resp *resp, size_t resp_size)
>  >  {
>  > -    IBV_INIT_CMD_RESP(cmd, cmd_size, CREATE_QP, resp, resp_size);
>  > +    return ibv_cmd_create_qp_expanded(pd, qp, attr, 0, cmd, cmd_size, resp, resp_size);
>  > +}
>
> Guys, please try to be careful about compatibility... we care about both
> new-kernel/old-libibverbs and old-kernel/new-libibverbs.  In this case
> think about what happens if we merge this into libibverbs and then a
> user tries that code on an old kernel.
>
>  - R.
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>