>+static inline void sdp_set_state(struct sock *sk, int state) >+{ >+ sk->sk_state = state; >+} Why have this abstraction? >- sk->sk_state = TCP_CLOSE; >+ sdp_set_state(sk, TCP_CLOSE); IMO, the previous code is simpler to maintain. - Sean