[ofa-general] [PATCH 1/4] sdp: Use sdp_set_state()

[Amir Mellanox]

It is easier to add debug prints for sdp state machine

On Thu, Jun 19, 2008 at 8:04 PM, Sean Hefty <sean.hefty at intel.com> wrote:

> >+static inline void sdp_set_state(struct sock *sk, int state)
> >+{
> >+      sk->sk_state = state;
> >+}
>
> Why have this abstraction?
>
> >-      sk->sk_state = TCP_CLOSE;
> >+      sdp_set_state(sk, TCP_CLOSE);
>
> IMO, the previous code is simpler to maintain.
>
> - Sean
>
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080619/5bbcdf7a/attachment.html>