[ofa-general] [PATCH] rdma_cm: Add debugfs entries to monitor rdma_cm connections

[Sean Hefty]

If the path is:

/sys/kernel/debug/rdma_cm/mthca0_rdma_id

do we really need to append '_rdma_id' at the end?  (I'll defer to others if
debugfs is the right location or not.)

>+	if (v == SEQ_START_TOKEN) {
>+		seq_printf(file,
>+		       "%-3s"
>+		       "%-8s"
>+		       "%-3s"
>+		       "%-5s"
>+		       "%-52s"
>+		       "%-52s"
>+		       "%-5s"
>+		       "%-3s"
>+		       "%-8s"
>+		       "\n",
>+		       "TP", "DEV", "PO", "NDEV", "SRC", "DST", "PS", "ST",
"QPN");

{snip}

>+		       seq_printf(file,
>+			       "%-3d"
>+			       "%-8s"
>+			       "%-3d"
>+			       "%-5s"
>+			       "%-52s"
>+			       "%-52s"
>+			       "%-5d"
>+			       "%-3d"
>+			       "%-8d"
>+			       "\n",
>+			       id_priv->id.route.addr.dev_addr.dev_type,
>+			       (id_priv->id.device) ? id_priv->id.device->name :
"",
>+			       id_priv->id.port_num,
>+			       (id_priv->id.route.addr.dev_addr.src_dev) ?
id_priv-
>>id.route.addr.dev_addr.src_dev->name : "",
>+			       local_addr,
>+			       remote_addr,
>+			       id_priv->id.ps,
>+			       id_priv->state,
>+			       id_priv->qp_num);

nit:
I'm
not
a
big
fan
of
one
parameter
per
line.

:)

It's not readily apparent to me what several of the headings are (TP, PO, PS,
ST) or what the numeric values map to (for TP, PS, ST).