[ofa-general] [PATCH] rdma_cm: Add debugfs entries to monitor rdma_cm connections

[Moni Shoua]

Thanks
Sean Hefty wrote:
> If the path is:
> 
> /sys/kernel/debug/rdma_cm/mthca0_rdma_id
> 
> do we really need to append '_rdma_id' at the end?  (I'll defer to others if
> debugfs is the right location or not.)
rdma_id is  a suffix that leaves room for more, or  in other works - I just wanted to leave room for other 
debug information in the future (e.g. number of count of total incoming connection on device)
> 
> nit:
> I'm
> not
> a
> big
> fan
> of
> one
> parameter
> per
> line.
> 
I wanted to make it easier to the code reader but I'm not a style fanatic :)
I'll change it if its critical.
> :)
> 
> It's not readily apparent to me what several of the headings are (TP, PO, PS,
> ST) or what the numeric values map to (for TP, PS, ST).
> 
TP=TyPe (Device type)
PO=POrt (Port Number)
PS=PortSpace
ST=STate

I tried to shorten the output line as much as possible to make the output looks as easy to 
read table (on most screen the output will be one line per rdma_id)
The same thought made me print only the numeric value and not it's string value.

Again, I'm not attached to this style and will change it if required.




> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>