[ofa-general] NetEffect, iw_nes and kernel warning
Roland Dreier
rdreier at cisco.com
Wed Jan 28 10:05:29 PST 2009
> > but actually I still don't see how it's safe for a net driver to
> > call skb_linearize() from its transmit routine, since there's a
> > chance that that will unconditionally enable BHs?
>
> It's simply not allowed.
>
> dev_queue_xmit() at a higher level can do __skb_linearize()
> because it does so before doing the rcu_read_lock_bh().
OK, thanks... what confused me is that several other drivers also do
skb_linearize() in their hard_start_xmit method... eg bnx2x,
via-velocity, mv643xx_eth. So there are several other lurking bugs to
deal with here I guess.
- R.
More information about the general
mailing list