[ofa-general] Re: [Repost][PATCH] opensm: Added support for select counters (xmit_wait)

[Nicolas Morey-Chaisemartin]

Le 19/07/2009 15:53, Sasha Khapyorsky a écrit :
> Hi Nicolas,
> 
> On 17:26 Tue 14 Jul     , Nicolas Morey-Chaisemartin wrote:
>> Support for xmit_wait counters was missing in the perfmgr though it was read from the mad and event plugin interface already handles it.
>> This patch adds support for it (tested and working with an event plugin)
>>
>> Tested-by: Jean-Vincent Ficet <jean-vincent.ficet at bull.net>
>> Signed-off-by: Nicolas Morey-Chaisemartin <nicolas at morey-chaisemartin.com>
>> ---
>> I think emails got mixed up the first time so here it is again.
>>
>>  opensm/include/opensm/osm_perfmgr_db.h |   23 ++++++-
>>  opensm/opensm/osm_perfmgr.c            |   30 +++++++-
>>  opensm/opensm/osm_perfmgr_db.c         |  124 +++++++++++++++++++++++++++++--
>>  3 files changed, 166 insertions(+), 11 deletions(-)
>>
>> diff --git a/opensm/include/opensm/osm_perfmgr_db.h b/opensm/include/opensm/osm_perfmgr_db.h
>> index 42a47bd..35b5ac3 100644
>> --- a/opensm/include/opensm/osm_perfmgr_db.h
>> +++ b/opensm/include/opensm/osm_perfmgr_db.h
>> @@ -109,6 +109,14 @@ typedef struct {
>>  } perfmgr_db_data_cnt_reading_t;
>>  
>>  /** =========================================================================
>> + * Port select count reading
>> + */
>> +typedef struct {
>> +	uint64_t xmit_wait;
>> +	time_t time;
>> +} perfmgr_db_sel_reading_t;
>> +
> 
> Why do we need a separate structure for this counter?
> 
> Sasha
> 

I don't think we really need one but in the event plugin interface xmit_wait counters are defined using another struct so I used a new structure to keep the whole thing homogeneous.

Nicolas