[ofa-general] Re: [Repost][PATCH] opensm: Added support for select counters (xmit_wait)

[Sasha Khapyorsky]

On 20:40 Sun 19 Jul     , Nicolas Morey-Chaisemartin wrote:
> >> + * Port select count reading
> >> + */
> >> +typedef struct {
> >> +	uint64_t xmit_wait;
> >> +	time_t time;
> >> +} perfmgr_db_sel_reading_t;
> >> +
> > 
> > Why do we need a separate structure for this counter?
> > 
> > Sasha
> > 
> 
> I don't think we really need one but in the event plugin interface xmit_wait counters are defined using another struct so I used a new structure to keep the whole thing homogeneous.

I guess that separate xmit wait counter in event plugin was done
assuming proprietary (vendor specific) counters implemented in some
switches and I think that it was done even before IBA 1.2.1 where
xmit_wait counter was included in a standard set.

Sasha