[ofa-general] Re: [PATCH ibverbs] Make the gid argument to ibv_attach_mcast and ibv_detach_mcast const

[Jason Gunthorpe]

On Mon, Jul 20, 2009 at 10:48:55AM -0700, Roland Dreier wrote:
> 
>  > -int ibv_attach_mcast(struct ibv_qp *qp, union ibv_gid *gid, uint16_t lid);
>  > +int ibv_attach_mcast(struct ibv_qp *qp, const union ibv_gid *gid, uint16_t lid);
> 
> Seems fine to me... I can't think of any risk of this breaking
> compatibility anywhere, but maybe I'm not being paranoid enough?

In C constness has no effect on the symbol binding or calling
convention, so it is ok - AFAIK.

I have also patches for mlx4 and mthca to suppress the compiler
warning that results from this patch. ipath is OK as is, and I'm not
sure where the iwarp stuff lives..

Jason