[ofa-general] Re: [PATCH ibverbs] Make the gid argument to ibv_attach_mcast and ibv_detach_mcast const
Jack Morgenstein
jackm at dev.mellanox.co.il
Wed Jul 22 02:02:18 PDT 2009
On Monday 20 July 2009 21:53, Jason Gunthorpe wrote:
> I have also patches for mlx4 and mthca to suppress the compiler
> warning that results from this patch. ipath is OK as is, and I'm not
> sure where the iwarp stuff lives..
>
Is this change really necessary?
Seems to me that you are creating cross-library
dependencies (at least with regard to compiler warnings) -- the user will now be
required to change the device libraries if libibverbs is upgraded. Also, if the
device libraries get changed, but libibverbs stays the same, I think you will also
get warnings if anyone tries to compile user-level apps.
Roland?
-Jack
More information about the general
mailing list