[ofa-general] Re: [PATCH] opensm/osm_mesh: Fix use after free problem in osm_mesh_node_delete

Sasha Khapyorsky sashak at voltaire.com
Mon Jul 27 10:06:27 PDT 2009


On 19:03 Fri 24 Jul     , Hal Rosenstock wrote:
> 
> When osm_mesh_node_delete is called, osm_switch_delete may already have
> been called so sw->p_sw is no longer valid to be used although it was
> being used to obtain num_ports.

And this looks like a bug in mesh code. Why does mesh need mesh node
structure after routing was calculated? LASH needs its switch info in
order to provide proper SL value to SA queries, but mesh info is not
needed then.

I think that proper way to fix this is to free mesh nodes when it is not
needed anymore and not on a next LASH cycle start (like LASH switches).

Sasha



More information about the general mailing list