[ofa-general] Re: [PATCH] opensm/osm_mesh: Fix use after free problem in osm_mesh_node_delete

[Hal Rosenstock]

On Mon, Jul 27, 2009 at 1:06 PM, Sasha Khapyorsky <sashak at voltaire.com>wrote:

> On 19:03 Fri 24 Jul     , Hal Rosenstock wrote:
> >
> > When osm_mesh_node_delete is called, osm_switch_delete may already have
> > been called so sw->p_sw is no longer valid to be used although it was
> > being used to obtain num_ports.
>
> And this looks like a bug in mesh code. Why does mesh need mesh node
> structure after routing was calculated? LASH needs its switch info in
> order to provide proper SL value to SA queries, but mesh info is not
> needed then.
>
> I think that proper way to fix this is to free mesh nodes when it is not
> needed anymore and not on a next LASH cycle start (like LASH switches).


It could be done this way but it's unclear whether that's the best approach
going forward. In the future, to minimize the changes on an update due to
topology change, we're  not sure how much state will need to be kept from
one iteration to the next. We suspect that a good solution to the update
problem will require preserving mesh state as well as lash state.

-- Hal



>
> Sasha
>  _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090727/2fc2fd79/attachment.html>