[nvmewin] ProcessIO Function

[Luse, Paul E]

Hi Alex-

I'm not totally sure I understand what you are trying to say but I think I do.  What does "In SNTI codes" mean?  I assume you're saying that there's some inconsistency with what some callers are assuming about the return value from ProcessIO() and, if so, good catch!  Clearly we cannot complete the same IO twice J  Haven't seen your formatNVM code yet but if any of the sub-commands you need to issue as art of handling formatNVM fails then you should fail the whole command gracefully.  Also, how does any of this relate to init state machine?

We may not have time to talk about this in the meeting so if you could reply and identify specific cases where you see callers of ProcessIO doing the wrong thing and propose a fix that would be great.  I don't believe we want the caller to have to complete the IO if processIO fails, procession should do that however just looking at the code doesn't consistently do that.  We should scrub it so that callers know that if procession fails that the IO has been completed and if it completes the IO has been issued.  We should also fix procession to complete all failures with appropriate error codes.

Thanks
Paul

From: Chang, Alex [mailto:Alex.Chang at idt.com]
Sent: Thursday, January 19, 2012 11:40 AM
To: Luse, Paul E; nvmewin at lists.openfabrics.org
Subject: ProcessIO Function

Hi all

I tested Format NVM last night and it basically works fine. However, when I re-visited the state machine, there is potential problem related to ProcessIo function, which completes the request back to Storport in error cases. The return value of ProcessIo only indicates whether the command had been issued to controller or not. It does NOT tell if it completes the request. In SNTI codes, Ray re-uses the Srb Extension to issue command(s). If ProcessIO fails, ASSERTION is called. Should I do the same if it fails when re-fetching Identify structures after Format NVM succeeds? Question is we don't want to complete the same request twice. We should talk about this later.

Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120119/92af45ec/attachment.html>