[nvmewin] Patch Review Request

Chang, Alex Alex.Chang at idt.com
Fri Jan 27 16:03:15 PST 2012


Hi all,
 
 I am re-sending the requst. Please disgard the previous one I sent last
week.
 Attached please find the implementation of handling Format NVM command
and Namespace Hot Add/Remove via IOCTL Pass Through:
- nvmeinit.c: Removed redundant codes in MSI enumeration.
- nvmestd.c : Main implementation of Format NVM
- nvmesnti.c :  
    a. Includes blocking IO for the target namespace while it's under
formatting  and namespace add back logic 
    b. Removed supporting Read/Write16 due to a bugcheck (0x19) when
running SCSI Compliance 2.0
- nvmestd.h : Added definition of FORMAT_NVM_INFO structure.
- nvmeioctl.h:  
    a. Added  three  more error codes, associated with Format NVM, that
can be returned in ReturnCode of SRB_IO_CONTROL .
    b. Added two IOCTL codes, NVME_HOT_ADD_NAMESPACE and
NVME_HOT_REMOVE_NAMESPACE.
 
Now, Format NVM can be done in two ways:
1. A single Format NVM command via IOCTL Pass Through request. The steps
driver takes to complete the request are:
a. Removes the target namespace(s) first
b. Issues Format NVM command
c. Re-fetch Identify Controller structure
d. Re-fetch Identify Namespace structure(s)
e. Adds back the formatted namespace(s)
 
2. With NVME_HOT_ADD/REMOVE_NAMESPACE IOCTL calls and a Format NVM
command via IOCTL Pass Through request:
a. Issue NVME_HOT_REMOVE_NAMESPACE IOCTL request to remove the target
namespace(s)
b. Issue Format NVM command via IOCTL Pass Through request, which
convers Step b, c and d of first method.
c. Issue NVME_HOT_ADD_NAMESPACE IOCTl request to add back the formatted
namespace(s)
 
Thanks,
Alex
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120127/ed3e1888/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FormatNVM.zip
Type: application/x-zip-compressed
Size: 91566 bytes
Desc: FormatNVM.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120127/ed3e1888/attachment.bin>


More information about the nvmewin mailing list