[nvmewin] Using StorPortAllocatePool in crashdump/hibernate context

[Harris, James R]

Hi all,

I noticed that there are a few places in crashdump/hibernate context where StorPortAllocatePool() is being called.  NVMeInitialize(), when ntldrDump == FALSE, is where I saw a few of these calls, but there may be others.

WDK says this can only be called at <= DISPATCH, but crashdump/hibernate mode is all run at DIRQL.  I've seen StorPortAllocatePool() hang during crash/hiber mode when testing other Storport drivers I've worked on in the past.  It may be helpful to put an assert in the NVMeAllocatePool routine to check IRQL to work through this once the driver starts getting used more for boot testing.

This should probably be fixed to use space in the DeviceExtension - crash/hiber mode can request up to a ~60KB extension.  If more space is needed, there are a couple of alternative methods (DumpRegion/RequestedDumpBufferSize, or global data buffers) to get more space, but fitting in the DeviceExtension is cleanest and least troublesome.

Regards,

-Jim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120606/de5e7a73/attachment.html>