[nvmewin] Patch Review Request

[Luse, Paul E]

Thanks Alex - LSI, you guys good?

FYI I met with some Msft folks last week and learned a few things about the storport performance options, I'll be running some experiments this week and let you all know what comes of them, I suspect the following though for my next patch:


-         Removal of MSI address decode method for determining vector/queue mapping.  It doesn't support logical mode which can be a function of OS (and is for Server 8).  Prefer the learning method over storport hints for MSI vector because its simple and works independent of OS or HW config as its based on what is happening on the system that its running on

-         Addition of DPC steering back to init; this controls the storport DPC completion, not the miniport, so it's a benefit regardless of what we do in the miniport.  Our DPC will run on the same core that our ISR runs on regardless of this setting.

-         Have some experimentation to do with concurrent channels, not clear whether this will work for us or not but will let you all know

I'll be setting up a meeting shortly for next week to review release plans.

Thx
Paul



From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Friday, March 02, 2012 12:31 PM
To: nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Patch Review Request

Thanks, Paul.
Please review the revised one in the attachment.

Alex

________________________________
From: Luse, Paul E [mailto:paul.e.luse at intel.com]
Sent: Friday, March 02, 2012 11:23 AM
To: Chang, Alex; nvmewin at lists.openfabrics.org
Subject: RE: Patch Review Request
Alex-

Looks good but I believe our coding style requires {} even with one liners following if/then/else (see excerpt below).  Please make that minor update and then it looks good from the Intel side.

Thx
Paul


For single line if statements:

if (<condition>) {

   <line>;

}


From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Friday, March 02, 2012 11:22 AM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Patch Review Request

Hi all,

I am attaching the recent changes in nvmeStd.c, which include two fixes:
1. Fix of system crash when INTx is being used to generate interrupts.
- Root cause:
The attempt to acquire MSI lock in DPC routine.
- Change:
Acquiring DpcLock instead if INTx is being used.

2. Fix of causing NVMe controller not responding when INTx is being used to generate interrupts.
- Root cause:
Programming Doorbell registers with improper Completion Queue Head Pointer values when looping through all completion queues.
- Change:
Resetting InterruptClaimed to FALSE after updating each Completion Queue Head Pointer via the associated Doorbell register.

Please review the changes and feel free to let me know if you have any comments or questions.
Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120305/3a3c58c3/attachment.html>