[nvmewin] Patch Review Request
Chang, Alex
Alex.Chang at idt.com
Fri Mar 2 11:30:47 PST 2012
Thanks, Paul.
Please review the revised one in the attachment.
Alex
________________________________
From: Luse, Paul E [mailto:paul.e.luse at intel.com]
Sent: Friday, March 02, 2012 11:23 AM
To: Chang, Alex; nvmewin at lists.openfabrics.org
Subject: RE: Patch Review Request
Alex-
Looks good but I believe our coding style requires {} even with one liners following if/then/else (see excerpt below). Please make that minor update and then it looks good from the Intel side.
Thx
Paul
For single line if statements:
if (<condition>) {
<line>;
}
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
Sent: Friday, March 02, 2012 11:22 AM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Patch Review Request
Hi all,
I am attaching the recent changes in nvmeStd.c, which include two fixes:
1. Fix of system crash when INTx is being used to generate interrupts.
- Root cause:
The attempt to acquire MSI lock in DPC routine.
- Change:
Acquiring DpcLock instead if INTx is being used.
2. Fix of causing NVMe controller not responding when INTx is being used to generate interrupts.
- Root cause:
Programming Doorbell registers with improper Completion Queue Head Pointer values when looping through all completion queues.
- Change:
Resetting InterruptClaimed to FALSE after updating each Completion Queue Head Pointer via the associated Doorbell register.
Please review the changes and feel free to let me know if you have any comments or questions.
Thanks,
Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120302/53924b31/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvmeStd.zip
Type: application/x-zip-compressed
Size: 23888 bytes
Desc: nvmeStd.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120302/53924b31/attachment.bin>
More information about the nvmewin
mailing list