[nvmewin] nvmewin Digest, Vol 5, Issue 4
Ravi Kumar
v25ravi at gmail.com
Wed May 2 20:55:46 PDT 2012
Hi All,
I apologize on my comments related to StartIo as I was referring the old
trunk base.
-----------------------
case SRB_FUNCTION_POWER:
pPowerSrb = (PSCSI_POWER_REQUEST_BLOCK)Srb;
Srb->SrbStatus = SRB_STATUS_SUCCESS;
status = NVMePowerControl(pAdapterExtension, pPowerSrb);
IO_StorPortNotification(RequestComplete, pAdapterExtension,
Srb);
---------------------------
which was corrected in updated code base.
Regards,
Ravi Kumar
On Thu, May 3, 2012 at 5:47 AM, <nvmewin-request at lists.openfabrics.org>wrote:
> Send nvmewin mailing list submissions to
> nvmewin at lists.openfabrics.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin
> or, via email, send a message with subject or body 'help' to
> nvmewin-request at lists.openfabrics.org
>
> You can reach the person managing the list at
> nvmewin-owner at lists.openfabrics.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of nvmewin digest..."
>
>
> Today's Topics:
>
> 1. Re: StartIo Function Return value for NVMePowerControl
> (Robles, Raymond C)
> 2. Re: patch status (Chang, Alex)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 2 May 2012 18:50:54 +0000
> From: "Robles, Raymond C" <raymond.c.robles at intel.com>
> To: "Chang, Alex" <Alex.Chang at idt.com>, Ravi Kumar
> <v25ravi at gmail.com>, "Luse, Paul E" <paul.e.luse at intel.com>
> Cc: "nvmewin at lists.openfabrics.org" <nvmewin at lists.openfabrics.org>
> Subject: Re: [nvmewin] StartIo Function Return value for
> NVMePowerControl
> Message-ID:
> <
> 49158E750348AA499168FD41D88983600C39E541 at FMSMSX105.amr.corp.intel.com>
>
> Content-Type: text/plain; charset="us-ascii"
>
> I must admit that I didn't quite understand the original problem stated
> and I should have asked for clarification sooner. Ravi, can you please
> explain the problem that you see in the SRB_FUNCTION_POWER case by using
> line numbers from the source code so that we can track where the potential
> issue before submitting a code patch?
>
> Are you inferring that the StartIo function will return FALSE even when
> the power request has been successfully completed? As Alex mentioned, the
> StartIo function will return TRUE in the case of handling a
> SRB_FUNCTION_POWER request. However, please note that we call
> StorPortNotification with the correct SrbStatus immediately after the call
> to NVMePowerControl. This will complete the command appropriately back to
> Storport (with the correct status). The StartIo will always return TRUE
> indicating the command was successfully started.
>
> Thanks,
> Ray
>
> From: nvmewin-bounces at lists.openfabrics.org [mailto:
> nvmewin-bounces at lists.openfabrics.org] On Behalf Of Chang, Alex
> Sent: Wednesday, May 02, 2012 9:23 AM
> To: Ravi Kumar; Luse, Paul E
> Cc: nvmewin at lists.openfabrics.org
> Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl
>
> Hi Ravi,
>
> For SRB_FUNCTION_POWER requests, NVMeStartIo always returns TRUE (Line
> 1205 in nvmestd.c) to indicate the request had been successfully
> initiated/processed. I am not sure why you mentioned it returns FALSE to
> Storport driver?
>
> Thanks,
> Alex
>
> ________________________________
> From: nvmewin-bounces at lists.openfabrics.org<mailto:
> nvmewin-bounces at lists.openfabrics.org> [mailto:
> nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:
> nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Ravi Kumar
> Sent: Tuesday, May 01, 2012 8:42 PM
> To: Luse, Paul E
> Cc: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
> Subject: Re: [nvmewin] StartIo Function Return value for NVMePowerControl
> Hi Paul,
>
> I'll put the patch with proper fix in a day and update the same.
>
> Regards,
> Ravi Kumar
> On Wed, May 2, 2012 at 1:14 AM, Luse, Paul E <paul.e.luse at intel.com
> <mailto:paul.e.luse at intel.com>> wrote:
> Thanks for the note Ravi. Can you please either put a patch together with
> the fix or simply enter a bug at
> https://www.openfabrics.org/resources/developer-tools/nvme-windows-development.html.
> Using the list to simply report something is a good way to make sure it
> gets lost :)
>
> From: nvmewin-bounces at lists.openfabrics.org<mailto:
> nvmewin-bounces at lists.openfabrics.org> [mailto:
> nvmewin-bounces at lists.openfabrics.org<mailto:
> nvmewin-bounces at lists.openfabrics.org>] On Behalf Of Ravi Kumar
> Sent: Sunday, April 29, 2012 10:32 PM
> To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
> Subject: [nvmewin] StartIo Function Return value for NVMePowerControl
>
> Hi,
>
> As per observation on Windows the function NVMeStarIo(NVMeStd.c) for Power
> management, in case NVMePowerControl()
> returns false it is still completed the request in NVMeStartIo and returns
> FALSE to StorPort driver. Whereas in case of StartIo returns FALSE StorPort
> driver treats IO has some issue and try to complete its own in
> AdapterControl call which create the BSOD to system
> (Multiple_IO_Request_Complete error).
> Don't we required to put the check in case failure of handle the power
> management system need not to be complete the Io as PortDriver makes it
> complete its own.
>
>
> Regards,
> Ravi Kumar
>
>
>
> --
> Regards,
> Ravi
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120502/5e133e45/attachment-0001.html
> >
>
> ------------------------------
>
> Message: 2
> Date: Thu, 3 May 2012 00:05:15 +0000
> From: "Chang, Alex" <Alex.Chang at idt.com>
> To: "Luse, Paul E" <paul.e.luse at intel.com>,
> "nvmewin at lists.openfabrics.org" <nvmewin at lists.openfabrics.org>
> Subject: Re: [nvmewin] patch status
> Message-ID:
> <548C5470AAD9DA4A85D259B663190D360105C2 at corpmail1.na.ads.idt.com>
> Content-Type: text/plain; charset="us-ascii"
>
> Hi Paul,
>
> The latest patch you added is working fine with me. Thanks a lot for the
> effort.
>
> Thanks,
> Alex
>
> ________________________________
> From: Luse, Paul E [mailto:paul.e.luse at intel.com]
> Sent: Wednesday, May 02, 2012 9:46 AM
> To: Chang, Alex; nvmewin at lists.openfabrics.org
> Subject: RE: patch status
>
> Cool, thanks. We already presented the slides at the last WG meeting so
> not real concerned about that, just want to get that patch applied and
> binaries released sooner than later
>
> Thx
> Paul
>
> From: Chang, Alex [mailto:Alex.Chang at idt.com]
> Sent: Wednesday, May 02, 2012 8:42 AM
> To: Luse, Paul E; nvmewin at lists.openfabrics.org
> Subject: RE: patch status
>
> Hi Paul,
>
> I have reviewed the slides and they are okay to me. Kwok might have some
> comments.
> As for the current sources, I started testing it yesterday, will let you
> know after more testing today.
>
> Thanks,
> Alex
>
> ________________________________
> From: nvmewin-bounces at lists.openfabrics.org<mailto:
> nvmewin-bounces at lists.openfabrics.org> [mailto:
> nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:
> nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Luse, Paul E
> Sent: Wednesday, May 02, 2012 8:05 AM
> To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
> Subject: [nvmewin] patch status
>
> Has everyone reviewed the last test/tested the release candidate that I
> sent out a while back? IDT/LSI?
>
> Thx
> Paul
>
> ____________________________________
> Paul Luse
> Sr. Staff Engineer
> PCG Server Software Engineering
> Desk: 480.554.3688, Mobile: 480.334.4630
>
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120503/02092092/attachment.html
> >
>
> ------------------------------
>
> _______________________________________________
> nvmewin mailing list
> nvmewin at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/nvmewin
>
>
> End of nvmewin Digest, Vol 5, Issue 4
> *************************************
>
--
Regards,
Ravi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120503/d1963a8d/attachment.html>
More information about the nvmewin
mailing list