[nvmewin] Comments swapped around??
    Chang, Alex 
    Alex.Chang at idt.com
       
    Fri May 18 12:17:49 PDT 2012
    
    
  
IDT is fine with the minor change.
Thanks,
Alex
________________________________
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Luse, Paul E
Sent: Friday, May 18, 2012 11:36 AM
To: Freyensee, James P; nvmewin at lists.openfabrics.org
Subject: Re: [nvmewin] Comments swapped around??
Looks like it J  I think this is minor enough we can treat this email as a patch request (as opposed to sending the actual fixed code out) and waiting for comments and questions so we just need an approval from Intel, LSI, and ADT at a minimum and then Ray can merge at his leisure after that.  I'll OK from the Intel side
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Freyensee, James P
Sent: Friday, May 18, 2012 10:33 AM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Comments swapped around??
In nvme.h currently in Trunk/:
typedef struct _MSI_MESSAGE_TBL
{
    /* The MSI message number granted from the system */
    ULONG MsgID;
    /* Physical address associated with the message */
    ULONG Data;
    /* Data associated with the message */
    STOR_PHYSICAL_ADDRESS Addr;
Are the comments in red swapped around?  When I see a variable 'Data' being used, I think of actual data values, which the second comment in red seems more appropriate for ULONG Data.
Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120518/2470621e/attachment.html>
    
    
More information about the nvmewin
mailing list