[nvmewin] Comments swapped around??

[Freyensee, James P]

Attached.  Only nvmeStd.h changed.

Jay

From: Robles, Raymond C
Sent: Monday, May 21, 2012 3:39 PM
To: Freyensee, James P; nvmewin at lists.openfabrics.org
Subject: RE: Comments swapped around??

James,

Can you please put together a patch to fix this comment issue.  You can just send out an email to the distribution list with the source files zipped for code review.

Thanks,
Ray

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Patel, Arpit
Sent: Friday, May 18, 2012 12:20 PM
To: Chang, Alex; Luse, Paul E; Freyensee, James P; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] Comments swapped around??

LSI also agrees.
Thanks.
Arpit.

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org]<mailto:[mailto:nvmewin-bounces at lists.openfabrics.org]> On Behalf Of Chang, Alex
Sent: Friday, May 18, 2012 12:18 PM
To: Luse, Paul E; Freyensee, James P; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] Comments swapped around??

IDT is fine with the minor change.

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Luse, Paul E
Sent: Friday, May 18, 2012 11:36 AM
To: Freyensee, James P; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: Re: [nvmewin] Comments swapped around??
Looks like it :)  I think this is minor enough we can treat this email as a patch request (as opposed to sending the actual fixed code out) and waiting for comments and questions so we just need an approval from Intel, LSI, and ADT at a minimum and then Ray can merge at his leisure after that.  I'll OK from the Intel side

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Freyensee, James P
Sent: Friday, May 18, 2012 10:33 AM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] Comments swapped around??

In nvme.h currently in Trunk/:

typedef struct _MSI_MESSAGE_TBL
{
    /* The MSI message number granted from the system */
    ULONG MsgID;

    /* Physical address associated with the message */
    ULONG Data;

    /* Data associated with the message */
    STOR_PHYSICAL_ADDRESS Addr;

Are the comments in red swapped around?  When I see a variable 'Data' being used, I think of actual data values, which the second comment in red seems more appropriate for ULONG Data.

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120522/73a99344/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvme_oo_reviews.zip
Type: application/x-zip-compressed
Size: 394585 bytes
Desc: nvme_oo_reviews.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20120522/73a99344/attachment.bin>