[nvmewin] Intel Byte Enable Patch

[Chang, Alex]

Hi Kris,

After reviewing your patch, I notice that, variable "IODB" (Line# 900 and 1013 in nvmeinit.c) is declared/initialized, but never gets used. I think you meant to read back the initial value of doorbell pointer with it?

Thanks,
Alex

________________________________
From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Murray, Kris R
Sent: Wednesday, June 12, 2013 4:45 PM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] ***UNCHECKED*** Intel Byte Enable Patch

All,

Attached is the patch to fix issues where accessing memory mapped controller register fields directly would generate single byte accesses across the PCIe bus by calling the StorPort functions to read those registers. The 4 places this is done are NVMeFindAdapter, NVMeInitCplQueue, NVMeSubQueue, and NVMeInitCallback.

Password: intel1234

Testing done using IOMeter and SCSI Compliance with logs attached.

Please review and provide feedback in the next couple weeks. Upon acceptance I'll rebase after the other patches make it through.

Thanks,
Kris

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20130627/20889e4b/attachment.html>