[nvmewin] PMC Patch For SCSI Compliance Fixes And Others

[Foster, Carolyn D]

Hi Alex, Yes I had something similar in mind for the log page.  This seems like a good approach.

Thanks,
Carolyn

From: Alex Chang [mailto:Alex.Chang at pmcs.com]
Sent: Monday, August 25, 2014 4:04 PM
To: Foster, Carolyn D; nvmewin at lists.openfabrics.org
Subject: RE: PMC Patch For SCSI Compliance Fixes And Others

Hi Carolyn,

I agree. Just finish the modifications accordingly. Let me brief the first one here and let me know what you think:
For both Error and Firmware slot pages, they are global to the device and need to be set as 0xFFFFFFFF.
For SMART/Health page, if bit0 of LPA is set, NSID needs to be set up as the namespace ID configured in LUN Extension. Otherwise, it needs to be set as 0xFFFFFFFF.

Thanks,
Alex


From: Foster, Carolyn D [mailto:carolyn.d.foster at intel.com]
Sent: Monday, August 25, 2014 2:55 PM
To: Alex Chang; nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: RE: PMC Patch For SCSI Compliance Fixes And Others

Hi Alex, I have a few comments about the patch.

In SntiBuildGetLogPageCmd:
Line 5347 - not all log pages are for the global controller.  SMART Health Information can be for a specific namespace if the Log Page Attributes bit for SupportsSMART_HealthInformationLogPage is set.  Also you can probably remove the PMC ADD comment.

Line 5372 - The numDwords calculation is a little confusing here.  It might be more clear if you calculated the number of dwords by dividing by the size of a UINT32 rather than by using the shift operation.

In SntiBuildFlushCmd:
Some of the comments in this function aren't accurate.  Line 5547 refers to WRITE, and line 5550 no longer matches line 5551, after the change.

Let me know if you have any questions.  Thanks!
Carolyn

From: nvmewin-bounces at lists.openfabrics.org<mailto:nvmewin-bounces at lists.openfabrics.org> [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Alex Chang
Sent: Friday, August 15, 2014 5:56 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>
Subject: [nvmewin] PMC Patch For SCSI Compliance Fixes And Others

Hi all,

I am sending out this patch for your review/test. The password is pmc123. Please provide your feedback as soon as possible and I will start to collect approvals on August 27.
This patch contains the following changes:
1. Fixed compiling errors when configured as /W3 and /WX. (nvmestd.c, nvmesnti.c)
2. Fixed to use Windows 8/SRB Extension defined Storage Request Block for Windows 8 and up. (nvmestd.c)
3. Fixed the following SCSI Compliance test failures: (nvmesnti.c)
- Supporting Log Sense command.
- Log Sense (Temperature Page)
- Log Sense (Informational Exceptional Page)
- Inquiry (Standard Page)
- Inquiry (Device ID Page)
- Inquiry (Unit Serial Page)
- Read Capacity 16 (Need to take care of null CDB buffer)
- Unmap (Anchor bit is not supported)
4. Fixed Get Log Page building, it needs to be 0's based number of DWORDs specified in DWORD 10 (nvmesnti.c).
5. Fixed a Report LUN bug that reports a zero-sized namespace when Namespace IDs are not contiguous (nvmesnti.c).
6. Fixed Flush command related bug that requires correct Namespace ID specified (nvmesnti.c).
7. Fixed system crash on Windows 8 and up when accessing CDB buffer in IO_StorPortNotification (nvmestd.c).

Unit Tests:
Tested the following on Windows 7, Server 2008, 8 and Server 2012:

-          Ran SCSI compliance tests

-          Ran SDStress

-          Ran IOmeter

-          Disk format (quick and slow) as MBR and GPT drive

-          Install/Uninstall, Enable/Disable driver
In addition, I also ran the NVMe SCSI Compliance Test using HCK 8.100.26795 on Windows 8.1 without any errors (see the attached results).

Thank you and have a great weekend!
Alex


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140825/cbe35153/attachment.html>