[nvmewin] Potential bug in OFA driver 1.3

[Parag Sheth]

HI Alex,



And just to add on top of it is another related BSOD in
IO_StorPortNotification() in nvmestd.c. The StorportDebugPrint statement
tries to dereference pCdb structure. And while using
STORAGE_REQUEST_BLOCKs, pCdb might be NULL in some cases. This will
straight away cause a blue screen while loading the driver (unless it is
using SCSI_REQUEST_BLOCK).



Thanks

Parag Sheth



*From:* Parag Sheth [mailto:parag.sheth at avagotech.com]
*Sent:* Wednesday, June 25, 2014 5:23 PM
*To:* 'nvmewin at lists.openfabrics.org'
*Subject:* RE: [nvmewin] Potential bug in OFA driver 1.3



Hi Alex,



To the best of my understanding, STORAGE_REQUEST_BLOCK will not be enabled
just by building a windows 8 version of driver. We need to add

hwInitData.SrbTypeFlags = SRB_TYPE_FLAG_STORAGE_REQUEST_BLOCK;

line to our DriverEntry routine. If we omit this line (in the current 1.3
version of driver this line is omitted), driver will use SCSI_REQUEST_BLOCK.



Thanks

Parag Sheth



*From:* Alex Chang [mailto:Alex.Chang at pmcs.com <Alex.Chang at pmcs.com>]
*Sent:* Wednesday, June 25, 2014 5:18 PM
*To:* Parag Sheth; nvmewin at lists.openfabrics.org
*Subject:* RE: [nvmewin] Potential bug in OFA driver 1.3



Hi Parag,



When you compile the driver for Windows 8 and up, STORAGE_REQUEST_BLOCK
will be used rather than SCSI_REQUEST_BLOCK. I wonder how you can have
SCSI_REQUEST_BLOCK + Windows 8 combination? And srbhelper is only compiled
in for Windows 8.



Thanks,

Alex



*From:* nvmewin-bounces at lists.openfabrics.org [
mailto:nvmewin-bounces at lists.openfabrics.org
<nvmewin-bounces at lists.openfabrics.org>] *On Behalf Of *Parag Sheth
*Sent:* Wednesday, June 25, 2014 5:12 PM
*To:* nvmewin at lists.openfabrics.org
*Subject:* [nvmewin] Potential bug in OFA driver 1.3



Hi All,



With the latest 1.3 driver, STORAGE_REQUEST_BLOCK support has been added
for windows 8 and up. Is this the only configuration allowed with Windows 8
or SCSI_REQUEST_BLOCK + windows 8 combination is allowed as well? If
allowed, than there are couple of bugs in the way srbhelper (from wdk) is
being used. Specifically SrbSetScsiData() and SrbGetScsiData() from
srbhelper do not handle SCSI_REQUEST_BLOCK properly and will cause command
failure.



Thanks

Parag Sheth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140625/4f88756b/attachment.html>