[nvmewin] PMC New Patch

[Alex Chang]

Thank you, Judy.
I added changes into nvmesnti.c on top of revision 73. The highlighted codes below was added in revision 82 by Yong, which was pushed after I sent out the patch. I certainly will re-base again after pushing Sandisk's patch and send it out for review/test.

Regards,
Alex

From: Judy Brock-SSI [mailto:judy.brock at ssi.samsung.com]
Sent: Sunday, March 16, 2014 10:36 AM
To: Alex Chang; nvmewin at lists.openfabrics.org
Subject: RE: PMC New Patch

Hi Alex,

I  was wondering why the following highlighted lines which are present in rev 83 have been deleted in the patch:

VOID SntiBuildFlushCmd(
    PNVME_SRB_EXTENSION pSrbExt
)
{
    /* Set up common portions of the NVMe WRITE command */
    memset(&pSrbExt->nvmeSqeUnit, 0, sizeof(NVMe_COMMAND));

    /* this Cmd is currently called not specific to one particular, but all namespaces */
    pSrbExt->nvmeSqeUnit.NSID = 0xFFFFFFFF;
    pSrbExt->nvmeSqeUnit.CDW0.OPC = NVM_FLUSH;

Thanks,
Judy

From: Alex Chang [mailto:Alex.Chang at pmcs.com]
Sent: Thursday, February 06, 2014 6:18 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>; Truong Nguyen-SSI
Subject: RE: PMC New Patch

Hi all,

Thanks to Carolyn for a quick feedback that CoreNum is no longer defined in Core Table, which causes a compiling error in debug build (Line# 1893 of nvmeinit.c). Sorry about the confusion and any inconveniences it may have caused. Please find the attached revised patch and password remains same.

Thanks,
Alex

From: Alex Chang
Sent: Friday, January 31, 2014 3:43 PM
To: nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>; Truong Nguyen-SSI (tru.nguyen at ssi.samsung.com<mailto:tru.nguyen at ssi.samsung.com>)
Subject: PMC New Patch

Hi all,

Please find the attached patch from PMC-Sierra. The password is pmc123. In order to speed up the entire process and meet our next release date, please review the changes and provide feedbacks as soon as possible. For each outstanding patch, we plan to collect feedbacks for about a week after it is being sent out. A revised patch shall be sent out to include the feedbacks. I will follow up for approval after a week or so to allow more testing and reviewing if necessary.
Summary of changes:

1.       SRB Extension support for Windows 8 and up.

Files changed: nvmeStd.c, nvmeSnti.c, nvmeStat.c, nvmePwrMgmt.c, nvmeInit.c and the related header files.

2.       PRP list building for IOCTL and internal requests.

Files changed: nvmeStd.c, nvmeInit.c and nvmestd.h.

3.       Performance issue in Windows 8/Server 2012.

File changed: nvmeStd.c (removed StorPortGetUncachedExtension calling in NVMeFindAdapter)

4.       NVMeInitAdminQueues return value.

File changed: nvmeStd.c (Instead of returning TRUE/FALSE, return Storport defined status)

5.       Paramlist length problem.

Files changed: nvmeSnti.c and nvmeSntiTypes.h (Program DW10 in submission entry in DWORDs for Write Buffer command translation)

6.       Removal of using mask bits as core index to allocate/identify core tables.

Files changed: nvmeStd.c, nvmeInit.c and the related header files.

7.       Implemented logical processor group defined by Windows.

Files changed: nvmeStd.c, nvmeInit.c and the related header files.

8.       NVMe reset handling issue.

File changed: nvmeStd.c (Need to wait until RDY bit is cleared to 0 after changing EN bit from 1 to 0)

9.       Core-MSI vector-Queue mapping, CMD_ENTRY synchronization and FreeQList access issues are related to using core mask bits as core index (#6) and no support for logical processor group (#7).
Platforms tested:

1.       Windows 7 64-bit

2.       Windows Server 2008 R2

3.       Windows 8 64-bit

4.       Windows Server 2012
Tests run;

1.       Installation(clean and update)/Un-Installation/Enable/Disable.

2.       IOMeter 4K Read/write combining in random/sequential manners.

3.       SCSC Compliance.

4.       SDStress

5.       Quick/full disk formats

Thanks,
Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20140317/1ef3c6c2/attachment.html>