[nvmewin] FW: Revised PMC Patch

[Thomas Freeman]

Alex, I have a question about FORMAT NVM.
When the drive is first powered on, the driver looks to see if the namespace is using metadata. If the namespace has metadata, it is not reported to Windows.
metadataSize = pLunExt->identifyData.LBAFx[flbas].MS;

But, if the user were to format a namespace with an LBAF that supports metadata, the driver would call NVMeFormatNVMHotAddNamespace, making that namespace available to Windows.
This issue existed before your fix, but it seems like now might be a good time to fix it.

Tom Freeman

Software Engineer, Device Manager and Driver Development
HGST, a Western Digital company
Thomas.Freeman at hgst.com<mailto:Thomas.Freeman at hgst.com>
507-322-2311

From: nvmewin-bounces at lists.openfabrics.org [mailto:nvmewin-bounces at lists.openfabrics.org] On Behalf Of Alex Chang
Sent: Monday, November 24, 2014 4:42 PM
To: nvmewin at lists.openfabrics.org
Subject: [nvmewin] Revised PMC Patch

Dear all,

It's been a week since I sent out the first version of PMC patch. Thanks to Suman and Judy for the feedback.
Here comes the revised patch (password:pmc123) and the changes include:

1.       New members added in Identify Namespace structure (nvme.h)

2.       Changed _NVMe_VERSION from struct to union (nvmeReg.h)

3.       New translation for Device Identification Page for Inquiry command, which will be approved soon in SCSI-to-NVMe Translation Specification V1.4  (nvmeSntiTypes.h and nvmeSnti.c)

4.       Added including stdlib.h in order to compile the changes in nvmeSnti.c (precomp.h)
Please review/test it at your earliest convenience and provide you feedback. I will start collecting approvals early December.

Thank you very much and Happy Thanksgiving!

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20141125/2b6b5fb8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PMC_FormatNVM_WHQL_Patch_V2_11242014.zip
Type: application/x-zip-compressed
Size: 192367 bytes
Desc: PMC_FormatNVM_WHQL_Patch_V2_11242014.zip
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20141125/2b6b5fb8/attachment.bin>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ATT00001.txt
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20141125/2b6b5fb8/attachment.txt>