[nvmewin] OFA NVMe Windows Driver Patch Submission Process

[Robles, Raymond C]

Hello,

As a friendly reminder, here is the process for submitting a patch. Please let me know if you have any questions.

Process:

-          Submitter needs to base their changes on the latest (and re-base/re-test prior to sending their patch).

-          They send the patch to the email list "nvmewin at lists.openfabrics.org".

-          Some review will happen over the reflector, the maintainer will send a message out that the db is locked when they're ready to apply the patch which will be once at least one member from each mandatory reviewing company on the review panel has approved (can be via email or con call if needed). Once the patch is applied, the maintainer will send an email out.

Patch Contents:

-          Code changes, short summary for SVN log, more verbose write up for release notes, confirmation of what Windows platforms had been tested.

-          Patch must follow the coding guidelines as attached.

-          All source files should be zipped up into a .zip file with password enabled. The zip file name should properly describe the main changes of the patch.

Reviews:

-          Patches submitted by anyone, email to distribution list "nvmewin at lists.openfabrics.org".

-          Patch submission should include time sensitivity/expectations.

-          Patch submission should include justification for the patch (what value will it add, and are tradeoffs what are they and why would we want to take a hit).  If multiple implementation options were considered, what data/reasoning was behind the implementation choice.

-          Patch submission should include files modified and explanation of code changes in each file.

-          At a minimum reviews need to be completed by Intel, PMC-Sierra, HGST, and Samsung representatives.

-          Reviews include compliance with coding guidelines (in SVN) as well as logic.

Unit Testing (all patches and release candidates require, at a minimum, the following testing):

-          1 hour of data integrity testing using sdstress (Microsoft Tool)

-          1 hour of heavy stress testing using IOMETER covering, at least, 512B, 4KB and 128KB ranging from 1 OIO to 64 OIO both sequential and random

-          Quick and slow format of both MBR and GPT partitioning

-          Microsoft SCSI Compliance, no failures except (warnings OK)

-          Additional testing with other tools is encouraged

-          Occurs in all supported OSs for the release

o    64-bit, Windows 7, 8.0, 8,1, server 2008R2 and 2012

o    32-bit, Windows 7, 8.0

-          Minimum test platform is latest QEMU.  Those with their HW should test on it as well.

-          QEMU is available at https://github.com/nvmeqemu/nvmeqemu

Thanks,
Ray

[cid:image001.png at 01CB3870.4BB88E70]
Raymond C. Robles
Non-Volatile Memory Solutions Group
Internal SSD Engineering
Intel(r) Corporation
Desk: 480.554.2600
Mobile: 480.399.0645

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150730/1310afcb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 1756 bytes
Desc: image001.png
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20150730/1310afcb/attachment.png>