[nvmewin] Issue with the latest OFA driver

[Robles, Raymond C]

Hi Tom,

I'm not sure what happened. I will look into it and fix the issue. Give me a few days.

Thanks...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Wednesday, February 08, 2017 12:32 PM
To: Robles, Raymond C <raymond.c.robles at intel.com>; nvmewin <nvmewin at lists.openfabrics.org>
Subject: RE: Issue with the latest OFA driver

Ray,
Unless I'm missing something, it appears the change to remove CNTID from Identify commands did not make it into 1.5

Here is the relevant code from the fix I submitted:

    /* Populate submission entry fields */
    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;
    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;

   pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;
    /* Set the type of identify command */
    pIdentifyCDW10->CNS = CNS;

    switch (CNS) {


Here is the same code in the trunk and the 1.5 release source:

/* Populate submission entry fields */

    pIdentify = &pNVMeSrbExt->nvmeSqeUnit;

    pIdentify->CDW0.OPC = ADMIN_IDENTIFY;



    pIdentifyCDW10 = (PADMIN_IDENTIFY_COMMAND_DW10) &pIdentify->CDW10;

    /* Set the type of identify command */

    pIdentifyCDW10->CNS = CNS;

    /* Select the controller to talk to */

    pIdentifyCDW10->CNTID = CNTID;



    switch (CNS) {





Can we get this updated, including the 1.5 builds?

Thanks,


Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Tom Freeman
Sent: Friday, November 11, 2016 8:41 AM
To: 'Robles, Raymond C' <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Ray,
In case you decide to include this fix in the latest release, here are the details:

The attached zip file, Ident-CNTIDPatch.zip (password = nvmehgst) contains:

1.       Source subdirectory containing the modified code based on revision 139.

2.       ControllerIdFix.patch containing the SVN patch to revision 139.

3.       README.txt - description of the problem and the fix.

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

From: Robles, Raymond C [mailto:raymond.c.robles at intel.com]
Sent: Tuesday, November 1, 2016 1:27 PM
To: Tom Freeman <thomas.freeman at wdc.com<mailto:thomas.freeman at wdc.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: RE: Issue with the latest OFA driver

Hi Tom,

Good find!

I'm of the opinion that it makes sense to get this patch in for the release we are about to announce. This is a minor fix for the Identify command that is isolated to two scenarios. Does anyone else have any objections or feel we should wait for this patch?

Depending on the feedback, we can go ahead and push a patch. I would say for now, please get the patch ready and then let's hold for feedback from the community reviewers... and go from there.

Thank you...
Ray

From: Tom Freeman [mailto:thomas.freeman at wdc.com]
Sent: Tuesday, November 01, 2016 9:08 AM
To: Robles, Raymond C <raymond.c.robles at intel.com<mailto:raymond.c.robles at intel.com>>; nvmewin <nvmewin at lists.openfabrics.org<mailto:nvmewin at lists.openfabrics.org>>
Subject: Issue with the latest OFA driver

Ray,
We've run into the following issue with the latest OFA driver.
During initialization, the driver request for NVME Identify Namespace fails with a status of "invalid field in command". Because of this, initialization fails and the device does not show up.
The underlying cause is that the driver puts the controller ID value into CDW10.CNTID. According to the NVMe spec, that is only valid when CNS = 0x12 or 0x13. For all other cases, "the host shall clear this field to 0h"

I'd like to make a patch for this. The fix would remove controller ID from any of the instance of NVMe Identify command (the driver does not use CNS = 0x12 or 0x13). How would you like me to proceed to coordinate with the current 1.5 testing?
Thanks,

Tom Freeman
Software Engineer, Device Manager and Driver Development

HGST, a Western Digital brand
Email:  Thomas.freeman at wdc.com<mailto:Thomas.freeman at wdc.com>
Office:  +1-507-322-2311

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer:
This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170209/1030bc0c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 1117 bytes
Desc: image001.gif
URL: <http://lists.openfabrics.org/pipermail/nvmewin/attachments/20170209/1030bc0c/attachment.gif>