[ofiwg] linux coding style question, or what is the libfabric interpretation of "resembles"

Jeff Squyres (jsquyres) jsquyres at cisco.com
Tue Mar 10 13:27:24 PDT 2015


+1 for a libfabric-wide git pre-commit hook.

I use a pre-commit hook to look for excess whitespace and ensure that the Cisco copyright is up-to-date at the top of the file(s) that I commit; it's fantastic.  Rote automation like this are exactly what computers are for.


> On Mar 10, 2015, at 4:09 PM, Howard Pritchard <hppritcha at gmail.com> wrote:
> 
> HI Folks,
> 
> A question has come up about how closely the libfabric code should adhere
> to the linux coding style.  
> 
> We've run a perl script that checks for adherence to the linux coding style
> against libfabric and it complains a lot.
> 
> The question is, how closely do we want to adhere to the linux coding style?
> 
> Should we consider adding a pre-commit hook that does style checking?
> I could see this might also reduce time with PR review nit picking if the
> reviewer(s) knew the that commits had to pass such a code style checking hook.
> 
> Howard
> 
> 
> 
> _______________________________________________
> ofiwg mailing list
> ofiwg at lists.openfabrics.org
> http://lists.openfabrics.org/mailman/listinfo/ofiwg


-- 
Jeff Squyres
jsquyres at cisco.com
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/




More information about the ofiwg mailing list