[ofiwg] [ofiwg/libfabric] Ofi bgq provider (#2500)

[Jeff Squyres (jsquyres)]

On Nov 2, 2016, at 6:01 PM, Coffman, Paul K. <pcoffman at anl.gov> wrote:
> 
> Jeff –
>  
> Do all of my new files need to have this dual BSD and GPLv2 license copyright in the header?

Yes; it's OpenFabrics rules.

>  And is it ok  for me to signoff on my own commits?

Yep!

I'm just about to turn in a review for your code.

In general, I think it looks awesome -- thanks for submitting!  I obviously can't comment on 90% of the code because I don't have a BGQ to run with, and I have no way of testing / etc.  I am providing some stylistic norms to conform to, and some comments on the code that I *can* read/grok (e.g., the configury, etc.).  Most of my comments are pretty minor and easily addressed.  Please take them all as constructive criticism!

-- 
Jeff Squyres
jsquyres at cisco.com
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/