[Openib-windows] Complib changes to support OpenSM in OpenIB

Yossi Leybovich sleybo at mellanox.co.il
Thu Aug 18 04:32:28 PDT 2005


Fab

While porting OpenSM to IBAL environment we encounter few problems 
In the past I sent you few patches but notice that most of them you did not
commit
I would appreciate if you review them again and find the time to commit them
in.
We want to be able to run OpenSM over OpenIB code.
I will list the changes that I recall:

1. cl_timers:
	a. 
	we tried to call cl_timer_start from within the timer call back, and
the thread enter to deadlock . We notice that cl_timer_star call 	to
cl_timer_stop which call to DeleteTimerQueueTimer with INVALI_HANDLE which
cause it to wait to all the callbacks to finish. 
	Msdn:"...If this parameter is INVALID_HANDLE_VALUE, the function
waits for the timer callback function to complete before returning. 	" So
if we call it within the timer callback we cause deadlock.

	

	The kernel implementation of cl_timer_start does not call
cl_timer_stop why ?( I am not sure that in the Kernel one can be sure that
he want get more DPCs)

	Solution to this problem is to add cl_timer_strat_cb function that
wont call to timer stop and be able to call 
      from within the callback

	b.
	I added few function for timers in order to add our perf_main tool
To OpenIB
	it include
	cl_get_time_staamp_usec
	cl_get_time_staamp_nsec
	cl_get_frequancy
	I can send patch to that.

2. cl_is_debug function - I send you patch for that , currently Linux
version of OpenSM use it so we need it in our complib as well
	I don't think its too risky

3. cl_qlock_pool.c - as Eitan said we need it in OpenSM for know and he will
change the code to work with external locks
4. Not related to the OpenSM  but I also sent patch for IB_COMPANY_NAME env
variable for installsp.exe can you apply it and I will also change the
ics_ver.h file


I think that for most of the things I already sent patches, If not just tell
me.
We really appreciate if you can apply the patches so we can move forward to
add OpenSM

- We intend to merge OpenSM ib_types.h to ibal ib_types.h but it takes time
, mean while we create copy of ib_types locally for OpenSM 

10x
Yossi 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20050818/4cf3a7ce/attachment.html>


More information about the ofw mailing list