[Openib-windows] RE: [patch] resource files

[Leonid Keller]

>> i've also changed ics_ver.h file to set product version equal to the file
>> version.

> I'm not quite sure what you mean here

Please, look at 'Product Version' of the WINIB binaries: it is
5.2.3790.<build_num>
'File Version', which you define in ics_ver.h, is common for all the
binaries and in fact is the product version.
So i've changed ics_ver.h to set product version equal to the file version.
Here is the change:

--------------------------------------------------------------
Index: S:/svn.wininf/trunk/inc/ics_ver.h
===================================================================
--- S:/svn.wininf/trunk/inc/ics_ver.h	(revision 165)
+++ S:/svn.wininf/trunk/inc/ics_ver.h	(revision 166)
@@ -49,6 +49,13 @@
 #define VER_FILEREV
114                  
 #endif
 
+#define VER_PRODUCTMAJORVERSION
VER_FILEMAJORVERSION
+#define VER_PRODUCTMINORVERSION
VER_FILEMINORVERSION
+#define VER_PRODUCTBUILD            	/* NT */     VER_FILEBUILD
+#define VER_PRODUCTBUILD_QFE
VER_FILEREV
+
 #if		(VER_FILEBUILD < 10)
 #define VER_FILEBPAD "000"
 #elif	(VER_FILEBUILD < 100)



-----Original Message-----
From: Fab Tillier [mailto:ftillier at silverstorm.com]
Sent: Wednesday, July 13, 2005 5:00 PM
To: 'Leonid Keller'; Yossi Leybovich
Cc: openib-windows at openib.org; Windows Group; Aviram Gutman
Subject: RE: [patch] resource files


> From: Leonid Keller [mailto:leonid at mellanox.co.il]
> Sent: Wednesday, July 13, 2005 2:15 AM
> 
> i've also changed ics_ver.h file to set product version equal to the file
> version.
> [in fact, it is the file version, that is equal to the product version,
but
> technically it is v.v. so far]

I'm not quite sure what you mean here - can you send a patch for this?

> I've also removed the company name from VER_FILEDESCRIPTION_STR of
resource
> files.

I think the resource files no longer have company names - Yossi's patch did
that
too.

> So ics_ver.h is the only file that contains company and product names and
it
> is easy to build the package with the desired ones.

Can you send a patch for this stuff?

Thanks,

- Fab
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20050713/c38720ca/attachment.html>