[Openib-windows] RE: [PATCH] FW version in vstat

[Fab Tillier]

Hi Yossi,

Thanks for the explanation - I just didn't understand what you were trying to do
in your earlier mail.

> > In the new verb API I started defining the FW version is a
> > 32-bit field in the CA attributes.  Can you do the same thing here?
>
> We use 64 bits for FW version (its 3 digits of 16 bits )

Ok, I've changed the structure in the new API to give the FW version 64-bits.  I
think it makes sense to have this field in the common structure, similar to the
device attributes in the Linux stack.

> [in the futur we might want to add cmd_if version to this number]

I don't see this being generic enough to warrant putting into the common
structure.

> So either we can change it to be 64bit or make it vendor specific

It's up to you if you would rather have the FW version in the common structure
or not - let me know either way.  If going on with the vendor specific data, I
can apply the patch you sent for the HCA driver changes.  However, I'd like to
see vstat account for that based on the reported vendor ID of the CA attributes.
That is, only extract the FW version from the vendor specific data if the vendor
ID is known to encode extra information there.

> My question was where do you want this header to be place?

The header could go either in the hw directory for that driver, or could go into
the inc\iba directory, but with a name indicative of its relationship to the
specific HW.

Thanks,

- Fab