[Openib-windows] RE: [PATCH] FW version in vstat

[Yossi Leybovich]

> -----Original Message-----
> From: Fab Tillier [mailto:ftillier at silverstorm.com] 
> Sent: Monday, November 07, 2005 9:23 AM
> To: 'Yossi Leybovich'
> Cc: openib-windows at openib.org
> Subject: RE: [PATCH] FW version in vstat
> 
> 
> Hi Yossi,
> 
> Thanks for the explanation - I just didn't understand what 
> you were trying to do in your earlier mail.
> 
> > > In the new verb API I started defining the FW version is a 32-bit 
> > > field in the CA attributes.  Can you do the same thing here?
> >
> > We use 64 bits for FW version (its 3 digits of 16 bits )
> 
> Ok, I've changed the structure in the new API to give the FW 
> version 64-bits.  I think it makes sense to have this field 
> in the common structure, similar to the device attributes in 
> the Linux stack.

I will add it to the current ca_attr API

> 
> > [in the futur we might want to add cmd_if version to this number]
> 
> I don't see this being generic enough to warrant putting into 
> the common structure.

OK . In the future I will add it to the vendor specific data.

> 
> > So either we can change it to be 64bit or make it vendor specific
> 
> It's up to you if you would rather have the FW version in the 
> common structure or not - let me know either way.  If going 
> on with the vendor specific data, I can apply the patch you 
> sent for the HCA driver changes.  However, I'd like to see 
> vstat account for that based on the reported vendor ID of the 
> CA attributes. That is, only extract the FW version from the 
> vendor specific data if the vendor ID is known to encode 
> extra information there.
> 

I will add it to the ca_attr struct , vendor with no FW version will set
this field to 0, and the vstat will ignore it.
I will send patch later today.

> > My question was where do you want this header to be place?
> 
> The header could go either in the hw directory for that 
> driver, or could go into the inc\iba directory, but with a 
> name indicative of its relationship to the specific HW.
> 
> Thanks,
> 
> - Fab
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20051107/b7b268f3/attachment.html>