[Openib-windows] RE: [patch] reregister of IP address to SM

[Fab Tillier]

Hi Yossi,

> From: Yossi Leybovich [mailto:sleybo at mellanox.co.il]
> Sent: Tuesday, November 29, 2005 4:05 AM
> 
> Fab
> 
> After adding IPoIB client reregister bit support the IPoIB rejoin to all
> multicast groups but it also need to reregister to all Ips
> What happen is that the Ips vector still mark the Ips as registered so
> it does not reregister them.
> We can mark them all as not register before reset or just dereg them.
> (I pesonaly think that IPoIB also need to deregister IPs when the
> Adapter destroy.
> Maybe need to add this flow to adapter_destroying).
> 
> This patch add the dereg to the reset flow.

The idea here seems good, some minor comments below.  Note that the patch won't
apply:

patching file ulp/ipoib/kernel/ipoib_driver.c
patch: **** malformed patch at line 44: @@ -2202,7 +2254,7 @@

Please fix the comments, and resend a patch against the SVN code, not some
private version.  If you must generate the patch from some private version at
least check that it applies to the SVN code.

Thanks,

- Fab