[Openib-windows] RE: [patch] reregister of IP address to SM

[Fab Tillier]

It would help if I actually sent the comments in the code, wouldn't it? ;)

> Index: ulp/ipoib/kernel/ipoib_adapter.h
> ===================================================================
> --- ulp/ipoib/kernel/ipoib_adapter.h	(revision 775)
> +++ ulp/ipoib/kernel/ipoib_adapter.h	(working copy)
> 
> @@ -394,4 +395,8 @@
>  ipoib_reg_addrs(
>  	IN				ipoib_adapter_t* const
> p_adapter );
> 
> +void
> +__ipoib_dereg_addrs(
> +	IN				ipoib_adapter_t* const
> p_adapter );
> +

Only static functions have the leading double underscore in their name.  This
helps make it clear from reading the function name whether it is static or
global.  If you're making the function global, remove the leading double
underscore.

>  #endif	/* _IPOIB_ADAPTER_H_ */
> Index: ulp/ipoib/kernel/ipoib_driver.c
> ===================================================================
> --- ulp/ipoib/kernel/ipoib_driver.c	(revision 775)
> +++ ulp/ipoib/kernel/ipoib_driver.c	(working copy)
> @@ -217,13 +217,63 @@
>  static void
>  __ipoib_ats_dereg_cb(
>  	IN				void
> *context );
> -
> +/*
>  static void
>  __ipoib_dereg_addrs(
>  	IN				ipoib_adapter_t* const
> p_adapter );
> +*/

Don't just comment out the old static declaration.  When you moved the
declaration to make the function global, the old declaration became dead code.
There's no reason to leave it around, commented out.  Please delete.

Thanks,

- Fab