[Openib-windows] A typo when destroying thecq_tinfo in the function pnp_ca_remove

[Fabian Tillier]

Hi Tzachi,

On 6/4/06, Tzachi Dar <tzachid at mellanox.co.il> wrote:
> Thanks for your fast response.
>
> However, while running some more tests I have received a different
> access violation with the following call stack:
>
> After looking at the error, it seems that the problem is after the
> lines:
>
>                /* ib_cq_thread() will release the cq_tinfo before exit.
> Don't
>                   reference cq_tinfo after signaling  */
>                h_cq_thread = cq_tinfo->ib_cq_thread;
>                cq_tinfo->ib_cq_thread = NULL;
>
>                cq_tinfo->ib_cq_thread_exit_wanted = TRUE;
>                cl_waitobj_signal( cq_tinfo->cq_waitobj );
>
> According to this lines, cq_tinfo shouldn't be used any more after
> signaling the event.
> However one line after that cq_tinfo->ib_cq_thread_id  is indeed being
> touched. This causes the AV of course.

Yes, a nice case of doing exactly what the comment says not to do.
Fixed in revision 372.

- Fab