[Openib-windows] Installing WSD from a directory without write permissions.

Fabian Tillier ftillier at silverstorm.com
Fri Jun 23 03:20:04 PDT 2006


On 6/22/06, Tzachi Dar <tzachid at mellanox.co.il> wrote:
> See bellow.
>
> Thanks
> Tzachi
>
> > -----Original Message-----
> > From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com]
> > On Behalf Of Fabian Tillier
> > Sent: Thursday, June 22, 2006 11:49 PM
> >
> > Hi Tzachi,
> >
> > On 6/22/06, Tzachi Dar <tzachid at mellanox.co.il> wrote:
> > >
> > > Committed in revision 388.
> >
> > Do you delete the files after they are copied to the perf directory?
> > Or did you leave them?  They should be deleted after the
> > install, not be left behind.
> >
> Currently the files are left behind (in the temp directory). If you fill
> that this is necessary, we can delete them.
>
> > In the future, as this is *not* a critical fix, please wait
> > for approval before checking in.
>
> After speaking with many people at the open IB community, it is hard to
> tell for how long one should wait for approve before check-in. Many
> people have different opinions. However, all people agree that if one
> has to wait for two weeks for some response, this is about time moving
> the responsibility to a different maintainer.

If a patch is not preventing operation, there is absolutely no reason
the code should be checked in without approval of the maintainer.  It
doesn't matter how long it takes - there are more important things
than this that take priority, and it's not up to you to decide when to
check things in.  There is no way that this patch would prevent you
from making forward progress with other work unless your development
process is broken.

I don't want to hear any BS about not being responsive when there is
plenty of blame to pass around for why things are taking so damn long.
 The MTHCA driver was supposed to be GA in *march*.  If you look at
the scope of the checkins being done on WSD, compared to the changes
in MTHCA, it's pretty clear that WSD is far more mature than MTHCA.

The maintainers of components are the gate keepers for that component.
 If you keep violating this, you will lose your checkin rights to the
SVN repository.  Check in rights are a privilege, not an entitlement.

- Fab




More information about the ofw mailing list