[Openib-windows] [PATCH] PNP dbg flag

Fabian Tillier ftillier at silverstorm.com
Tue Sep 12 09:20:40 PDT 2006


Hi Yossi,

On 9/12/06, Yossi Leybovich <sleybo at mellanox.co.il> wrote:
> Fab
>
> Complib assume that the DBG_PNP = (1<<1) ,this patch convert all units
> to use (1<<1) for the PNP flag

Why not just change complib to define CL_DBG_PNP as (1<<2) so that it
matches the most common use?  Note also that the AL_DBG_PNP flag is
never passed to complib - it is there to control debug output from
AL's PnP managers.

> This patch also pass 0 as the debug flags of IOU ,this because  complib
> still use the old version of debug levels ( not levels and flags that we
> insert lately).

Why not just pass the flags, and define the bits in the flags so that
the PNP bit is in the correct location?

> I will work on patch to convert complib to support WPP and the new flags
> and level mechanism.

Ok.  One question - what are all the reserved WPP flag bits for?

- Fab




More information about the ofw mailing list