[Openib-windows] [PATCH] PNP dbg flag

[Yossi Leybovich]

> -----Original Message-----
> From: ftillier.sst at gmail.com [mailto:ftillier.sst at gmail.com] 
> On Behalf Of Fabian Tillier
> Sent: Tuesday, September 12, 2006 7:21 PM
> To: Yossi Leybovich
> Cc: openib-windows at openib.org
> Subject: Re: [Openib-windows] [PATCH] PNP dbg flag
> 
> Hi Yossi,
> 
> On 9/12/06, Yossi Leybovich <sleybo at mellanox.co.il> wrote:
> > Fab
> >
> > Complib assume that the DBG_PNP = (1<<1) ,this patch 
> convert all units 
> > to use (1<<1) for the PNP flag
> 
> Why not just change complib to define CL_DBG_PNP as (1<<2) so 
> that it matches the most common use?  Note also that the 
> AL_DBG_PNP flag is never passed to complib - it is there to 
> control debug output from AL's PnP managers.
> 
I did not know who else count on the complib CL_DBG_PNP
(opensm/tests...)
so I changed the units I familiars with to match complib.

> > This patch also pass 0 as the debug flags of IOU ,this because  
> > complib still use the old version of debug levels ( not levels and 
> > flags that we insert lately).
> 
> Why not just pass the flags, and define the bits in the flags 
> so that the PNP bit is in the correct location?

Complib use the CL_ENTER /CL_EXIT macros that check CL_DBG_PNP.
In the current code if we pass g_iou_dbg_flags to the complib ,these
prints will be printed regardless to the trace level. 
The reason I create this patch was because I got many prints of the
cl_pnp every time the opensm move from down to up. Each time I got all
the fun entry /exit prints even that my trace level was ERROR.

BTW
We need to pass 0 to the IOC pnp function too.

I will create new patch.


> 
> > I will work on patch to convert complib to support WPP and the new 
> > flags and level mechanism.
> 
> Ok.  One question - what are all the reserved WPP flag bits for?

To match between the dbg flags and the wpp flags. In the original flags
you left few bits that you skip on , I put them as reserved in the WPP.
Now we can use the same masks for dbg and wpp.

> 
> - Fab
> 
> 
>