[ofw] changes to ib_wc committed to svn

Fab Tillier ftillier at windows.microsoft.com
Wed Jul 30 09:22:23 PDT 2008


> From: Tzachi Dar [mailto:tzachid at mellanox.co.il]
> Sent: Wednesday, July 30, 2008 1:10 AM
>
> Checksum offload will only work UD QPC. In other words, for connected
> mode ipoib it will not work.

Oh, that's too bad.  But I suppose that could be added later in the HW without needing SW changes if we put the checksum info in the recv_opt field.

> I don't mind putting the 8 bits in the recv_opt field.
> Currently recv_opt is defined as ib_recv_opt_t which is uint_32.
>
> There is also a list of macros that is defined as
> #define IB_RECV_OPT_IMMEDIATE           0x00000001
> #define IB_RECV_OPT_FORWARD             0x00000002
> #define IB_RECV_OPT_GRH_VALID           0x00000004
> #define IB_RECV_OPT_VEND_MASK           0xFFFF0000
>
> So I suggest to make one more mask:
> #define IB_RECV_OPT_CHECK_SUM           0x0000FF00
> And we will be able to use this extra place.

Sounds good to me!  Probably add a comment indicating that this field is identical to the NDIS type, though.

Thanks,
-Fab



More information about the ofw mailing list