[ofw] [RFC] [PATCH 11/12] winverbs\uvp:add poll_cq_array() tointerface

[Fab Tillier]

Sounds fine to me.  If you move the ND entrypoints out of the uvp_interface_t, you can probably revert the version number to what it was before they were added.

-Fab

-----Original Message-----
From: Sean Hefty [mailto:sean.hefty at intel.com]
Sent: Monday, March 17, 2008 9:16 PM
To: Fab Tillier; ofw at lists.openfabrics.org
Subject: RE: [ofw] [RFC] [PATCH 11/12] winverbs\uvp:add poll_cq_array() tointerface

>Looking at the code, right now it returns the version that it filled in.
>Nobody checks the return, and it's not told what version is requested.  I'd
>probably consider this a bug - the version should be set by the caller, and the
>callee should return the requested version.

Here's what I've come up with:

uvp_interface_t is left unchanged, and I've defined a new struct and DLL export:

typedef struct _uvp3_interface
{
        uvp_interface_t                 uvp2;

        uvp3_poll_cq_array              poll_cq_array;
        // other version 3 calls go here... probably want to move ND calls here

}       uvp3_interface_t;

typedef ib_api_status_t
(AL_API *uvp_get_interface_n_t)(
        IN              const   uint32_t                        version,
        IN      OUT                     void*                   p_uvp_interface,
        IN      OUT                     size_t*         p_uvp_interface_size);

This should more easily let use move the uvp interface forward without breaking
various implementations of ibal.  Comments?

- Sean