[ofw] patch: [mlx4] Add minor function (is_power_of_2) andfixcompilation issues on C++.

[Sean Hefty]

Actually there are several header files that have been ported from Linux.  This
should probably be discussed in one of the working group meetings to determine
what needs to be done.

 

 

  _____  

From: Hefty, Sean 
Sent: Wednesday, May 21, 2008 4:36 PM
To: Hefty, Sean; 'Tzachi Dar'; ofw at lists.openfabrics.org
Subject: RE: [ofw] patch: [mlx4] Add minor function (is_power_of_2)
andfixcompilation issues on C++.

 

Someone mentioned to me that the list implementations were pulled directly from
the linux/list.h header file, and after checking that is the case.  I believe
that code is GPLv2 and needs to be removed from the SVN tree.

 

 

Converting to windows lists can be a separate patch, but should be
straightforward.  Maybe we can combine that with removing it from complib as
well.

 

 

The main reason for this changes is to allow including this files from C++.

 

Since new is a keyword in C++ things simply don't compile.

 

As for the option to remove this lists all together:

In an ideal world you are probably right. Given the limited time that we had, we
have found that using the 

Linux code without changes saves us a lot of time.

 

Thanks

Tzachi

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080521/97c1d0fd/attachment.html>