[ofw] patch: [mlx4] Add minor function (is_power_of_2)andfixcompilation issues on C++.

[Smith, Stan]

Tzachi,
  There is not much to discuss. The offending code must be removed as
soon as possible.
 
The presence of 'any' identifiable sections of Linux kernel header files
infects the entire WinOF module such that it can not exist under a BSD
license.  The entire module code base becomes GPL'ed (infected) due to
the identifiable presence of Linux kernel code (parts of Linux header
files).  Once the module is GPL'ed, those who help us the most will be
forbidden to examine the module source and likely the entire WinOF
stack; don't bite the hand that feeds you.
 
This is a serious situation, given the changing OFA Windows contributor
agreement.
Please correct this situation immediately.
 
I would suggest using BSD code or get creative with the C pre-processor
and use Windows functions wrapped in macros.
 
thank you,
 
stan.

________________________________

From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Sean Hefty
Sent: Wednesday, May 21, 2008 4:49 PM
To: Hefty, Sean; 'Tzachi Dar'; ofw at lists.openfabrics.org
Subject: RE: [ofw] patch: [mlx4] Add minor function
(is_power_of_2)andfixcompilation issues on C++.



Actually there are several header files that have been ported from
Linux...  This should probably be discussed in one of the working group
meetings to determine what needs to be done.

 

 

________________________________

From: Hefty, Sean 
Sent: Wednesday, May 21, 2008 4:36 PM
To: Hefty, Sean; 'Tzachi Dar'; ofw at lists.openfabrics.org
Subject: RE: [ofw] patch: [mlx4] Add minor function (is_power_of_2)
andfixcompilation issues on C++.

 

Someone mentioned to me that the list implementations were pulled
directly from the linux/list.h header file, and after checking that is
the case.  I believe that code is GPLv2 and needs to be removed from the
SVN tree.

 

 

Converting to windows lists can be a separate patch, but should be
straightforward.  Maybe we can combine that with removing it from
complib as well.

 

 

The main reason for this changes is to allow including this files from
C++.

 

Since new is a keyword in C++ things simply don't compile.

 

As for the option to remove this lists all together:

In an ideal world you are probably right. Given the limited time that we
had, we have found that using the 

Linux code without changes saves us a lot of time.

 

Thanks

Tzachi

	 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080523/ec81c59c/attachment.html>