[ofw] patch: [mlx4] Add minor function (is_power_of_2)andfixcompilation issues on C++.

[Smith, Stan]

________________________________

From: Tzachi Dar [mailto:tzachid at mellanox.co.il] 
Sent: Saturday, May 24, 2008 10:58 AM
To: Smith, Stan; Hefty, Sean
Cc: ofw at lists.openfabrics.org
Subject: RE: [ofw] patch: [mlx4] Add minor function
(is_power_of_2)andfixcompilation issues on C++.


Hi Smith,
Hello Tzachi. You can call me Stan.
 
I'm not sure why you address me in this mail, I didn't add these files. 
 
You happened to respond to Sean's email and are recognized as a senior
developer in the Mellanox windows effort.  Therefore, you should be
aware of the GPL src code rules and the implications of GPL code being
contributed to an open source project.
 
Next week I will be running a commercial GPL code recognition tool over
the entire openib-windows src base which will identify offending files.
Since you mentioned knowledge of existing GPL'ed files please proceed
with their replacement.
Developers must 'always' be aware of the src code they contribute to an
open source project.
 
stan.
 
 
In any case, the offending code must be removed and that is agreed.
If you (and Sean) can let us know which are the offending files, they
will be removed.
 
Thanks
Tzachi


________________________________

	From: Smith, Stan [mailto:stan.smith at intel.com] 
	Sent: Friday, May 23, 2008 7:39 PM
	To: Hefty, Sean; Tzachi Dar
	Cc: ofw at lists.openfabrics.org
	Subject: RE: [ofw] patch: [mlx4] Add minor function
(is_power_of_2)andfixcompilation issues on C++.
	
	
	Tzachi,
	  There is not much to discuss. The offending code must be
removed as soon as possible.
	 
	The presence of 'any' identifiable sections of Linux kernel
header files infects the entire WinOF module such that it can not exist
under a BSD license.  The entire module code base becomes GPL'ed
(infected) due to the identifiable presence of Linux kernel code (parts
of Linux header files).  Once the module is GPL'ed, those who help us
the most will be forbidden to examine the module source and likely the
entire WinOF stack; don't bite the hand that feeds you.
	 
	This is a serious situation, given the changing OFA Windows
contributor agreement.
	Please correct this situation immediately.
	 
	I would suggest using BSD code or get creative with the C
pre-processor and use Windows functions wrapped in macros.
	 
	thank you,
	 
	stan.

________________________________

	From: ofw-bounces at lists.openfabrics.org
[mailto:ofw-bounces at lists.openfabrics.org] On Behalf Of Sean Hefty
	Sent: Wednesday, May 21, 2008 4:49 PM
	To: Hefty, Sean; 'Tzachi Dar'; ofw at lists.openfabrics.org
	Subject: RE: [ofw] patch: [mlx4] Add minor function
(is_power_of_2)andfixcompilation issues on C++.
	
	

	Actually there are several header files that have been ported
from Linux...  This should probably be discussed in one of the working
group meetings to determine what needs to be done.

	 

	 

	
________________________________


	From: Hefty, Sean 
	Sent: Wednesday, May 21, 2008 4:36 PM
	To: Hefty, Sean; 'Tzachi Dar'; ofw at lists.openfabrics.org
	Subject: RE: [ofw] patch: [mlx4] Add minor function
(is_power_of_2) andfixcompilation issues on C++.

	 

	Someone mentioned to me that the list implementations were
pulled directly from the linux/list.h header file, and after checking
that is the case.  I believe that code is GPLv2 and needs to be removed
from the SVN tree.

	 

	 

	Converting to windows lists can be a separate patch, but should
be straightforward.  Maybe we can combine that with removing it from
complib as well.

	 

	 

	The main reason for this changes is to allow including this
files from C++.

	 

	Since new is a keyword in C++ things simply don't compile.

	 

	As for the option to remove this lists all together:

	In an ideal world you are probably right. Given the limited time
that we had, we have found that using the 

	Linux code without changes saves us a lot of time.

	 

	Thanks

	Tzachi

		 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/ofw/attachments/20080525/0500f310/attachment.html>